BelongsToMany: Add support for junction aliases #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
allow-belongstomany-to-define-a-junction-alias-147
branch
from
0b8d939 to
0cb2d87
Compare
sukhwinder33445
requested changes
Jul 9, 2025
If you wonder why the junction's actual alias (if there's one) is not overridden: The only place where this is processed, is where `resolve()` is called. And that's, at the moment, only the `Query`. But this uses aliases defined earlier and in case of `BelongsToMany` relations, this is done when a relation path is resolved. Which is why you will find a call to `getThroughAlias()` there. resolves #147
nilmerg
force-pushed
the
allow-belongstomany-to-define-a-junction-alias-147
branch
from
7d3261c to
22cb565
Compare
nilmerg
force-pushed
the
allow-belongstomany-to-define-a-junction-alias-147
branch
from
22cb565 to
1cc1143
Compare
sukhwinder33445
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wonder why the junction's actual alias (if there's one) is not overridden: The only place where this is processed, is where
resolve()is called. And that's, at the moment, only theQuery. But this uses aliases defined earlier and in case ofBelongsToManyrelations, this is done when a relation path is resolved. Which is why you will find a call togetThroughAlias()there.resolves #147