Modernize code #155
Open
Modernize code #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastianLedererIcinga
changed the base branch from
main
to
8.4/8.5-compatibility
Jan-Schuppik
reviewed
Dec 9, 2025
Jan-Schuppik
reviewed
Dec 9, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
a48b99b to
7d98bbe
Compare
Jan-Schuppik
approved these changes
Dec 10, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
7d98bbe to
e194919
Compare
sukhwinder33445
requested changes
Dec 11, 2025
…tructor implementation
Where an InvalidArgumentException was caused by a simple type mismatch, typed parameters will now casue a TypeError instead. Tests have been adjusted accordingly.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
87bf2cd to
a83714b
Compare
sukhwinder33445
approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
8.4/8.5-compatibility
branch
2 times, most recently
from
e925968 to
40c7f0b
Compare
BastianLedererIcinga
force-pushed
the
8.4/8.5-compatibility
branch
from
40c7f0b to
be36f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.