Modernize code #63
Open
Modernize code #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
support-php-85
branch
from
52f1357 to
415ad2b
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
4bc935f to
422c34e
Compare
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
The return type of BaseFilter::setBaseFilter can be changed to static.
BastianLedererIcinga
previously approved these changes
Dec 10, 2025
sukhwinder33445
force-pushed
the
modernize-code
branch
from
01fc4fa to
2030a2d
Compare
sukhwinder33445
commented
Dec 10, 2025
src/Filter.php
Outdated
| * @return Condition | ||
| */ | ||
| public static function equal($column, $value) | ||
| public static function equal(string $column, array|bool|float|int|string|DateTime|null $value): Condition |
Contributor
Author
There was a problem hiding this comment.
Please remove the param types for $value. The phpDoc is fine.
Please remove this from other methods where DateTime can be specified as a parameter.
src/Filter.php
Outdated
Comment on lines
172
to
179
| if (! $rule instanceof Equal && ! $rule instanceof Unequal) { | ||
| throw new InvalidArgumentException(sprintf( | ||
| 'Rule must be of type %s or %s, got %s instead', | ||
| Equal::class, | ||
| Unequal::class, | ||
| get_php_type($rule) | ||
| )); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This can be removed now.
src/Filter.php
Outdated
Comment on lines
223
to
230
| if (! $rule instanceof Like && ! $rule instanceof Unlike) { | ||
| throw new InvalidArgumentException(sprintf( | ||
| 'Rule must be of type %s or %s, got %s instead', | ||
| Like::class, | ||
| Unlike::class, | ||
| get_php_type($rule) | ||
| )); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is superfluous and can be removed now.
src/Filter.php
Outdated
Comment on lines
499
to
501
| switch (true) { | ||
| case $rule instanceof All: | ||
| return $this->matchAll($rule, $row); |
Contributor
Author
There was a problem hiding this comment.
You can use match() instead of switch() and then remove the default case.
Jan-Schuppik
force-pushed
the
modernize-code
branch
from
5c7ad36 to
0e8fbc5
Compare
sukhwinder33445
force-pushed
the
support-php-85
branch
2 times, most recently
from
6408fa8 to
d67ed2a
Compare
sukhwinder33445
force-pushed
the
support-php-85
branch
from
d67ed2a to
dd095bd
Compare
lippserd
dismissed
BastianLedererIcinga’s stale review
The base branch was changed.
Contributor
Author
|
Please rebase. |
properties, parameters and returntypes
extended in ipl/Sql/Filter/...
In, NotIn, Exists, NotExists
implemented in ipl/Sql/Filter/...
In, NotIn, Exists, NotExists
prevent the error:
Typed property
Icinga\Module\Icingadb\Widget\Detail\ObjectStatistics::$baseFilter
must not be accessed before initialization
e.g. ipl\Html\FormElement::addElementLoader() allows to call the method with null
Depends on removing the ipl\Sql\Filter\InAndNotInUtils trait
removing parameter uniontypes & unnecessary typechecking, change switch to match
Jan-Schuppik
force-pushed
the
modernize-code
branch
from
0e8fbc5 to
20d500b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.