Skip to content

Fix calldata validation for tuple types#10

Open
emdin wants to merge 1 commit intoigralabsfrom
fix/tuple-type-validation
Open

Fix calldata validation for tuple types#10
emdin wants to merge 1 commit intoigralabsfrom
fix/tuple-type-validation

Conversation

@emdin
Copy link

@emdin emdin commented Mar 6, 2026

Summary

  • Custom action form validation rejected all tuple and tuple[] parameter types, blocking proposals with struct-based function parameters (e.g. diamondCut's FacetCut[])
  • isValidSingleValue had no case for tuple, falling through to default: return false
  • isValidCalldataValue rejected empty arrays for tuple[], which is valid (e.g. empty facet cuts)

Test plan

  • Create a custom action proposal targeting a Diamond contract and selecting diamondCut method
  • Verify the red validation dot no longer appears on the Custom section when tuple params are present
  • Verify "Add Action" is no longer blocked by tuple validation
  • Verify non-tuple parameter validation still works correctly

🤖 Generated with Claude Code

The calldata validation in the custom action form rejected all tuple and
tuple[] parameter types (e.g. diamondCut's FacetCut[] struct), making it
impossible to submit proposals with struct-based function parameters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant