feat(pty): share single Docker container across terminal tabs#88
Merged
Conversation
2ec2364 to
5f913d0
Compare
5f913d0 to
1848c9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedContainer(Arc-wrapped) that creates a single Docker container at app startup withsleep infinityas entrypointdocker execinstead of creating a new containerArcreference) is droppedPtyProviderTypeenum to separate config-time provider selection from runtimePtyProvider(which carries theArc<SharedContainer>)Test plan
cargo clippy --all-features -- -D warningspassescargo clippy -- -D warningspasses (without feature)cargo test— 381 tests passcargo run --features pty-test_container -- --use-pty-test-container, open multiple tabs with Cmd+T, verify all share one container (docker psshows singleinfraware_*container)