feat(pty): allow custom Docker image via CLI flag#89
Merged
Conversation
Add CLI flag to override the default debian:bookworm-slim image for the Docker PTY backend. Fix bug where create_container() ignored the user-specified image. Handle registry port in image:tag parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pty-test-container-imageCLI flag to override the defaultdebian:bookworm-slimDocker image for the PTY backend (acceptsimage:tagformat, defaults tolatestwhen tag omitted)create_container()ignored the user-specified image and always useddebian:bookworm-slimregistry.example.com:5000/myimage:v1)pty-backends.md,CLAUDE.md) with new flag usage and configurationTest plan
cargo run --features pty-test_container -- --use-pty-test-container— uses defaultdebian:bookworm-slimcargo run --features pty-test_container -- --use-pty-test-container --pty-test-container-image ubuntu:24.04— pulls and runs Ubuntucargo clippy --all-features -- -D warnings— no warningscargo test— all tests pass