-
Notifications
You must be signed in to change notification settings - Fork 4
Reference implementation of HERACLES Assembler tools #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Signed-off-by: Flavio Bergamaschi <flavio@intel.com>
Delete this CODEOWNERS file as it is not required in a sub-directory
Update README.md to be inline with latest codebase
Update README.md with correct reference to the PGM
Not required after for the new assembler
Not required in the new assembler
kylanerace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove old style execution instructions
kylanerace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kylanerace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
christopherngutierrez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. All changes have been addressed and tested python scripts locally.
* Reference implementation of the HERACLES Assembler tools --------- Signed-off-by: Flavio Bergamaschi <flavio@intel.com> Co-authored-by: Flavio Bergamaschi <faberga+github@users.noreply.github.com> Co-authored-by: Ernesto Zamora Ramos <sidezrw+github@users.noreply.github.com> Co-authored-by: Chris Wilkerson <ChrisWilkerson+github@users.noreply.github.com> Co-authored-by: Jose Rojas Chaves <joserochh+github@users.noreply.github.com> Co-authored-by: Kylan Race <kylanerace+github@users.noreply.github.com> Co-authored-by: Christopher Gutierrez <christopherngutierrez+github@users.noreply.github.com> Co-authored-by: Hamish Hunt <hamishun+github@users.noreply.github.com> Co-authored-by: Jack Crawford <jlhcrawford+github@users.noreply.github.com> Co-authored-by: Minxuan Zhou <minxuanzh+github@users.noreply.github.com> Co-authored-by: Wen Wang <wenwang3122+github@users.noreply.github.com> Co-authored-by: Adish Vartak <avartak+github@users.noreply.github.com> Co-authored-by: Michael Steiner <g2flyer+github@users.noreply.github.com> Co-authored-by: Avinash Alevoor <avinash-alevoor+github@users.noreply.github.com> Co-authored-by: Rashmi Agrawal <agrawalr-dev+github@users.noreply.github.com>
Proposed changes
This is a Reference implementation of the Assembler tools for the HERACLES platform
Types of changes
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
This PR brings into the Encrypted Computing SDK a reference implementation of the Assembler tools for the HERACLES platform.