Enable RustlerPrecompiled to Fetch NIFs from Exstatic (private repo)#7
Merged
Primebrook merged 7 commits intomainfrom Feb 8, 2025
Merged
Enable RustlerPrecompiled to Fetch NIFs from Exstatic (private repo)#7Primebrook merged 7 commits intomainfrom
Primebrook merged 7 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building on #4, which introduced RustlerPrecompiled for fetching precompiled binaries, this PR adds the
Exstatic.ReleaseHelpermodule to enable authenticated downloads from the Exstatic repo. Since Exstatic is private, direct public URLs are not an option. Instead, this module implements GitHub’s private asset download flow, for retrieving the NIF binaries.I also added an up to date CHANGELOG.md in this PR.
Challenges with using RustlerPrecompiled for private GitHub releases
As discussed in philss/rustler_precompiled#65 (comment), fetching assets from private repositories requires an extra couple of steps because:
EXSTATIC_GITHUB_TOKEN(I'll add this to the README in a follow up).