Skip to content

Conversation

@JCLemme
Copy link

@JCLemme JCLemme commented Oct 4, 2025

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • [~] All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    Turtles cannot equip or otherwise interact with pattern grids

  • What is the new behavior (if this is a feature change)?
    Turtles can now equip pattern grids to write patterns: see below
    Allow turtles to craft Refined Storage patterns Advanced-Peripherals-Features#125

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
    Not to my knowledge

  • Other information:
    I'd like to add unit tests if this project is set up for them

@zyxkad
Copy link
Collaborator

zyxkad commented Oct 4, 2025

Would you mind do the PR on dev/0.8 instead as we are not receiving any new features on 0.7?
Also make sure you run ./gradlew checkstyleMain to have a uniformed style in the respoistry.

@SirEndii
Copy link
Member

SirEndii commented Oct 4, 2025

You know what, feel free to keep this PR open but as zyxkad said, please port it also to dev/0.8(1.19.2)

I usually don't want to add new features to 0.7, but I don't see myself working a lot on 0.8 the near future to finish a release - so it won't hurt to release it here too, we can then just add a hint in the docs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 32a5db0
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/18657115082
Jar Files AdvancedPeripherals PR 790
Expires At 2026-01-18T15:50:51Z

@JCLemme
Copy link
Author

JCLemme commented Oct 4, 2025

On it.

JCLemme and others added 5 commits October 7, 2025 14:14
…utercraft/peripheral/PatternGridPeripheral.java

Co-authored-by: Kevin Z <zyxkad@gmail.com>
Signed-off-by: John Lemme <jclemme@proportionallabs.com>
# Conflicts:
#	src/main/java/de/srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
@SirEndii
Copy link
Member

I will hopefully find time next week to review all PRs

Comment on lines +79 to +81
if (pattern.isEmpty()) {
throw new IllegalStateException("Pattern is blank");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AP uses error states insteads of exceptions, feel free to catch one but return a MethodResult instead. This is used to simplify the return errors for the users instead of using pcall.

Check

Feel free to create new constants, usually I want to document them on the site. But try to use existing ones instead. You can use #withInfo to add information, like for the catches and Exception#getMessage() you use

@SirEndii SirEndii mentioned this pull request Oct 20, 2025
3 tasks
@SirEndii
Copy link
Member

I need to test this and #791 ingame
Not a huge fan of two different ways to create patterns for each peripheral - but I need to test it to decide what we will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants