-
-
Notifications
You must be signed in to change notification settings - Fork 92
Add pattern grid turtles #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/1.21.1
Are you sure you want to change the base?
Conversation
…of pattern and get detailed information
|
Would you mind do the PR on dev/0.8 instead as we are not receiving any new features on 0.7? |
|
You know what, feel free to keep this PR open but as zyxkad said, please port it also to dev/0.8(1.19.2) I usually don't want to add new features to 0.7, but I don't see myself working a lot on 0.8 the near future to finish a release - so it won't hurt to release it here too, we can then just add a hint in the docs |
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
|
On it. |
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
...srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
Outdated
Show resolved
Hide resolved
…utercraft/peripheral/PatternGridPeripheral.java Co-authored-by: Kevin Z <zyxkad@gmail.com> Signed-off-by: John Lemme <jclemme@proportionallabs.com>
# Conflicts: # src/main/java/de/srendi/advancedperipherals/common/addons/computercraft/peripheral/PatternGridPeripheral.java
|
I will hopefully find time next week to review all PRs |
| if (pattern.isEmpty()) { | ||
| throw new IllegalStateException("Pattern is blank"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AP uses error states insteads of exceptions, feel free to catch one but return a MethodResult instead. This is used to simplify the return errors for the users instead of using pcall.
Check
AdvancedPeripherals/src/main/java/de/srendi/advancedperipherals/common/util/StatusConstants.java
Line 8 in 24975c7
| public enum StatusConstants { |
Feel free to create new constants, usually I want to document them on the site. But try to use existing ones instead. You can use #withInfo to add information, like for the catches and Exception#getMessage() you use
|
I need to test this and #791 ingame |
What kind of change does this PR introduce? (Bug fix, feature, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Turtles cannot equip or otherwise interact with pattern grids
What is the new behavior (if this is a feature change)?
Turtles can now equip pattern grids to write patterns: see below
Allow turtles to craft Refined Storage patterns Advanced-Peripherals-Features#125
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
Not to my knowledge
Other information:
I'd like to add unit tests if this project is set up for them