Skip to content

Add :IMPORT-FROM option to DEFPACKAGE #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add :IMPORT-FROM option to DEFPACKAGE #2335

wants to merge 2 commits into from

Conversation

@MattHeffron
Copy link
Contributor

This resolves #2334

@MattHeffron MattHeffron self-assigned this Oct 30, 2025
@pamoroso
Copy link
Contributor

When building this PR on Linux Mint 22.1 Cinnamon I get a blank Medley window and the following error:

paolo@lispmachine:~/medley/medley$ ./scripts/loadup-all.sh -apps
>>>>> START loadup-init
"/home/paolo/bin/lde" "/home/paolo/medley/medley/internal/loadups/starter.sysout" -id "loadup_init_1" -title "Medley::loadup_init_1" -g 1024x768 -sc 1024x768 -noscroll
MEDLEYDIR: "/home/paolo/medley/medley"
LOGINDIR: "/home/paolo/medley/medley/loadups/build/logindir"
GREET FILE: "/home/paolo/medley/medley/loadups/build/loadup-init.init"
REM.CM FILE: ""
VMEM FILE: "/home/paolo/medley/medley/loadups/build/logindir/vmem/lisp_loadup_init_1.virtualmem"
+++++ SUCCESS +++++
..... files created .....
-rw-rw-r-- 1 paolo paolo 4426752 Oct 30 11:03 /home/paolo/medley/medley/loadups/build/init.dlinit
-rw-rw-r-- 1 paolo paolo 150218 Oct 30 11:03 /home/paolo/medley/medley/loadups/build/init.dribble
-rw-rw-r-- 1 paolo paolo 4279808 Oct 30 11:03 /home/paolo/medley/medley/loadups/build/init.sysout
-rw-rw-r-- 1 paolo paolo 55826 Oct 30 11:02 /home/paolo/medley/medley/loadups/build/RDSYS
-rw-rw-r-- 1 paolo paolo 43012 Oct 30 11:02 /home/paolo/medley/medley/loadups/build/RDSYS.LCOM
-rw-rw-r-- 1 paolo paolo 89183 Oct 30 11:02 /home/paolo/medley/medley/loadups/build/I-NEW
-rw-rw-r-- 1 paolo paolo 70676 Oct 30 11:02 /home/paolo/medley/medley/loadups/build/I-NEW.LCOM
<<<<< END loadup-init

>>>>> START loadup-mid-from-init
"/home/paolo/bin/ldeinit" "/home/paolo/medley/medley/loadups/build/init.dlinit" -id "loadup_mid_from_init_1" -title "Medley::loadup_mid_from_init_1" -g 1024x768 -sc 1024x768 -noscroll -NF
MEDLEYDIR: "/home/paolo/medley/medley"
LOGINDIR: "/home/paolo/medley/medley/loadups/build/logindir"
GREET FILE: "/home/paolo/medley/medley/greetfiles/NOGREET"
REM.CM FILE: "/home/paolo/medley/medley/loadups/build/loadup-mid-from-init.cm"
VMEM FILE: "/home/paolo/medley/medley/loadups/build/init-mid.sysout"
evaluating initial expressions:
PACKAGE-CONVERSION-TABLE.EXPRESSIONS
LLSUBRS.EXPRESSIONS
FILEIO.EXPRESSIONS
EXTERNALFORMAT.EXPRESSIONS

*Error* URAID Called:
Enter the URaid
#:CL::SYMBOL-PACKAGE

<
pr2335error

I'm at mth52--Add-IMPORT-FROM-to-DEFPACKAGE/c2d89e5 on Medley and nhb-rewrite-version-parser-v2/3d09555 on Maiko.

@pamoroso
Copy link
Contributor

I forgot to include the dribble files, here they are from another build that failed in the same way: loadups.zip

@nbriggs
Copy link
Contributor

nbriggs commented Oct 30, 2025

Same.

>>>>> START loadup-mid-from-init
"/Users/briggs/Projects/maiko/darwin.x86_64/ldeinit" "/Users/briggs/Projects/medley/loadups/build/init.dlinit" -id "loadup_mid_from_init_1" -title "Medley::loadup_mid_from_init_1" -g 1024x768 -sc 1024x768 -noscroll -NF
MEDLEYDIR: "/Users/briggs/Projects/medley"
LOGINDIR: "/Users/briggs/Projects/medley/loadups/build/logindir"
GREET FILE: "/Users/briggs/Projects/medley/greetfiles/NOGREET"
REM.CM FILE: "/Users/briggs/Projects/medley/loadups/build/loadup-mid-from-init.cm"
VMEM FILE: "/Users/briggs/Projects/medley/loadups/build/init-mid.sysout"
evaluating initial expressions:
PACKAGE-CONVERSION-TABLE.EXPRESSIONS
LLSUBRS.EXPRESSIONS
FILEIO.EXPRESSIONS
EXTERNALFORMAT.EXPRESSIONS

*Error* URAID Called:
Enter the URaid
#:CL::SYMBOL-PACKAGE

< l u
  0 :    0x11934 : #:RAID
  1 :    0x1191e : #:FAULTAPPLY
  2 :    0x118d2 : #:\INTERPRETER
  3 :    0x11898 : #:U-CASE
  4 :    0x11880 : #:\DEFINEDEVICE
  5 :    0x11868 : #:\NULLDEVICE
  6 :    0x11848 : #:\EVALFORM
  7 :    0x11834 : #:EVAL
  8 :    0x11814 : #:INITIALEVALQT
  9 :    0x11802 : #:CL::T

< f 3
IVAR -------
  11894 : 0x   0  0x 662  *local* #:X  #:CL::NULL

## STACK BF at 0x11896 ##
[cnt=0 ]
ivar : 0x1894
>> Bf's ivar says 0x11894 vs. IVar says 0x1192c
Fname is #:U-CASE
## STACK FX at 0x11898 ##
[cnt = 0 ]
 #alink           0x188a 
 fnhead   0x2fc47c 
 nextblock        0x18cc 
 pc               0xe0 
 nametbl  0x7c0bac 
 #blink           0x0 
 #clink           0x62b 
  118a2 : 0x  7b  0xe0b0  *local* [pvar0]   "CL::NULLTERNALFORMATTYPE#"
  118a4 : 0x   0  0x   0  *local* [pvar1]   #:CL::NIL
  118a6 : 0x  2e  0x15be  *local* [pvar2]   {unknown}0x2e15be
  118a8 : 0x   e  0x   9  *local* [pvar3]   9
  118aa : 0x   0  0x 662  *local* [pvar4]   #:CL::NULL
  118ac : 0x   e  0x   8  *local* [pvar5]   8
  118ae : 0x   e  0x  4c  *local* [pvar6]   76
  118b0 : 0x   0  0x   0  *local* [pvar7]   #:CL::NIL
  118b2 : 0x  7f  0xb8f0  *local* [pvar8]   {#:\UNBOXEDHUNK3}0x7fb8f0
  118b4 : 0x   e  0x   8  *local* [pvar9]   8
  118b6 : 0x   0  0x   0  *local* [pvar10]   #:CL::NIL
  118b8 : 0xffff  0xffff  *local* [pvar11]   [variable not bound]
  118ba : 0xffff  0xffff  *local* [pvar12]   [variable not bound]
  118bc : 0xffff  0xffff  *local* [pvar13]   [variable not bound]

@MattHeffron
Copy link
Contributor Author

I didn't change any code except to add the :IMPORT-FROM handling, and that doesn't use CL:SYMBOL-PACKAGE.
I'm guessing that something happened with the compilation, so I'll try doing the manual (TCOMPL 'LLPACKAGE) again in a clean sysout, and then retry building the loadup.

@nbriggs
Copy link
Contributor

nbriggs commented Oct 30, 2025

The previous LCOM was made with compile-file, according to the comments in it, as was the version in CLTL2. So, i'm not sure if that's COMPILE-FILE or FAKE-COMPILE-FILE... since it's an LCOM.

@rmkaplan
Copy link
Contributor

rmkaplan commented Oct 30, 2025 via email

@nbriggs
Copy link
Contributor

nbriggs commented Oct 30, 2025

Yes - if you FAKE-COMPILE-FILE it you can do a loadup successfully.

@MattHeffron
Fix a couple of variable reference typos.
9d32cfe 
Change the FILETYPE to be :FAKE-COMPILE-FILE (per #2336)
@MattHeffron
Copy link
Contributor Author

Per @nbriggs I recompiled with FAKE-COMPILE-FILE by changing the FILETYPE of LLPACKAGE to be :FAKE-COMPILE-FILE.
This also resolves #2336

@MattHeffron MattHeffron linked an issue Oct 30, 2025 that may be closed by this pull request
LLPACKAGE wrong? FILETYPE property #2336
Open
@nbriggs
Copy link
Contributor

nbriggs commented Oct 30, 2025

I can do a loadup with the revised LLPACKAGE.LCOM. I don't have anything to test the :IMPORT-FROM functionality.

@pamoroso
Copy link
Contributor

It now builds successfully but I'm not sure I'm testing the feature properly as I'd expect the call to CREATEW to work here:

defpackage-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masinter masinter Awaiting requested review from masinter

@hjellinek hjellinek Awaiting requested review from hjellinek

At least 1 approving review is required to merge this pull request.

Assignees

@MattHeffron MattHeffron

Labels

None yet

Projects

common lisp
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LLPACKAGE wrong? FILETYPE property DEFPACKAGE has :IMPORT but not :IMPORT-FROM

5 participants

@MattHeffron @pamoroso @nbriggs @rmkaplan