A couple of memory optimizations #599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray` and `Data.Array.Byte.ByteArray`
lehins
force-pushed
the
lehins/memory-optimizations
branch
2 times, most recently
from
6862daa to
d72cb08
Compare
lehins
force-pushed
the
lehins/memory-optimizations
branch
from
d72cb08 to
3cac086
Compare
`OutputVRF` is small in size and is persisted in memory for some time, since we keep around block headers for a while. In order to not contribute to pinned memory fragmentation and not to retain unnecessary bytes it is better to switch to unpinned `ByteArray` from pinned `ByteString`
As it turns out `cborg` library whenever decoing `ByteString` it will take a slice in constant time of the original large buffer that is being fed to the decoder, while it can't do the same when decoding `ByteArray#`. Concidering that for `PackedBytes` this intermediate buffer is short lived, because it is only needed for packing operation, it totally makes sense to not make a redundant copy of this buffer.
lehins
force-pushed
the
lehins/memory-optimizations
branch
from
3cac086 to
a087b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches
OutputVRFto useByteArrayin order to not contribute to pinned memory fragmentation.Also it switches decoding of
PackedBytesto useByteStringfor temporary buffer to avoid unnecessary copy.Couple of useful
FromCBOR/ToCBORinstances were added to accommodate above changesChecklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)