Improve docker image creation#2035
Draft
aleeusgr wants to merge 8 commits intoIntersectMBO:masterfrom
Draft
Conversation
Contributor
|
Thanks for the patch, this is a solid approach! I did run into a few problems testing it: the schema files are missing from the image, and the docs are missing some setup steps. You correctly mentioned on Discord the requirements were vague. I've tried to add some more implementation guidance there. Can you take a look, and let me know what you think? |
Author
|
Thanks. I've been unable to focus on the task last week. There's a bit of a crisis I have to deal with 😶🪫 |
… verification - Copy cardano-db-sync binary into a minimal Ubuntu image. - Bake schema directory into the image and embed a deterministic SCHEMA_HASH. - Add entrypoint template that verifies the runtime schema checksum matches the baked hash and execs the binary with --schema-dir /schema. - Replace fragile heredoc with a template + sed substitution in the Dockerfile. - Add build script to copy tarball/schema into build context and compute SCHEMA_HASH. - Add test-image.sh to validate image behavior (help, schema mount, modified-schema detection, binary presence).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
address #2012
Checklist
fourmoluon version 0.17.0.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.