Even more CDDL #5382
Merged
Even more CDDL #5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
changed the base branch from
master
to
aniketd/more-cddl-deduplication
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
from
c3b9ed7 to
6fda464
Compare
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
2 times, most recently
from
ea10f9d to
472c126
Compare
lehins
approved these changes
Nov 3, 2025
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Looks great! I love it!
Only a couple of minor suggestions
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary/CDDL.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/even-more-cddl
branch
2 times, most recently
from
d256cb1 to
35f959a
Compare
* Rename and move metadata, matadatum and metadatum_label definitions to core, along with transaction_index. * Remove metadata_hash and just use auxiliary_data_hash everywhere.
Rename era-name-prefixed definitions with meaningful structural names that are easier to reuse.
* Make native_script fields era-prefixed as and when they are introduced * Add smart constructors for script types in core * Fix script_n_of_k for eras after allegra
lehins
force-pushed
the
aniketd/even-more-cddl
branch
from
35f959a to
74c9049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some more of the checklist in #5367 and is the third part of #5194
Checklist
Tests added or updated when needed.CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).