Merged
Conversation
This essentially takes all of the variables that were previously "package level" and moves them inside of a PseudoTCP struct. Correspondingly, it takes all of the "package level" functions and makes them methods of the PseudoTCP struct. This facilitates simpler creation, configuration, initialization as well as allows multiple instances of the PseudoTCP struct to be instantiated in parallel if necessary.
invisv-team
approved these changes
Feb 20, 2025
This moves from a hard coded ConnectToProxy method to a user configurable proxyClient interface which allows for: - The caller to provide their own options to the masque proxy - The caller to choose between an http2 or http3 (or any other TCP+UDP proxy) - Future tests which can mock the proxyClient allowing for more granular unit-style testing
invisv-team
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially takes all of the variables that were previously "package level" and moves them inside of a PseudoTCP struct. Correspondingly, it takes all of the "package level" functions and makes them methods of the PseudoTCP struct.
This facilitates simpler creation, configuration, initialization as well as allows multiple instances of the PseudoTCP struct to be instantiated in parallel if necessary.
I'm opening this as a draft for now because I'd like feedback on this strategy, but I'd also like to refactor the
connectToProxymethod so that it could be a caller/instantiator provided config. That would do a number of things: