This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Fix that some memory is not allocated by the host allocator#816
Open
Fix that some memory is not allocated by the host allocator#816
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
BenjaminTrapani
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Optimize memory usage in FRI protocol implementation by avoiding unnecessary vector allocations and copies.
What changed?
TerminateCodeword<F>fromVec<F>to&'a [F]to avoid unnecessary cloningHow to test?
Run the existing test suite, particularly focusing on:
test_commit_prove_verify_successin the FRI testsWhy make this change?
This change improves memory efficiency in the FRI protocol implementation by:
These optimizations are particularly important for performance in resource-intensive zero-knowledge proof generation.