Fixes the example mod to run using modern IsaacScript versions. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed yarn.lock to resolve a package manager conflict with package-lock.json. Updated tsconfig.json for correct extends/luaPlugins paths and fixed luaBundle and luaBundleEntry fields. Added src/bundleEntry.ts and refactored main.ts to use a main function.
Member
|
i think some files were missing in this PR so I will just re-init a project and copy over the edits |
Member
|
yeah that found a bunch more changes, but nonetheless thanks for brining this to my attention, it was very badly out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Multiple different kinds of package manager lock files were found ("package-lock.json" & "yarn.lock"). You should delete the ones that you are not using so that this program can correctly detect your package manager.)