In heartbeat handle, proactively check for missed min_time#1088
Open
In heartbeat handle, proactively check for missed min_time#1088
Conversation
spirali
force-pushed
the
proactive-retract
branch
from
81b2519 to
d85be13
Compare
Member
|
Why is this done in the heartbeat handle? Seems a bit weird. Shouldn't this be a separate periodic background check? |
Collaborator
Author
It should be, I just did not want to introduce a new config option 🙈. |
Member
|
This is an internal optimization, I don't think we have to make it configurable. |
Collaborator
Author
|
It should be configurable for tests; otherwise, tests would be too long & dependent on an internal constant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization where worker proactively retracts prefilled tasks that missed min_time.
This speeds up to returning the task non-prefilled state and makes the scheduling more deterministic.