Skip to content

Add an option to display current entry ranking#20

Draft
Tegu wants to merge 1 commit intoIune:masterfrom
Tegu:issue-5/display-entry-places
Draft

Add an option to display current entry ranking#20
Tegu wants to merge 1 commit intoIune:masterfrom
Tegu:issue-5/display-entry-places

Conversation

@Tegu
Copy link
Copy Markdown
Contributor

@Tegu Tegu commented Feb 26, 2020

The spacing and styling may need some additional work.

I had a look at the issue list and decided to try implementing issue #5. I am not entirely satisfied with the appearance and the element dimension and offset calculations might also need a closer look. However, since a new release is apparently coming soon, I decided to share what I have got so far although this may not be ready for that release yet. Thus, I made a draft pull request.

The spacing and styling may need some additional work.
@Iune
Copy link
Copy Markdown
Owner

Iune commented Feb 27, 2020

Thank you very much for this contribution! I think that this is a very nice starting point for displaying the entry rankings on the scoreboards, though the spacing may need to be slightly adjusted.

I was aiming to have version v5.0.2 (the upcoming release) to be a relatively smaller one with mainly bug fixes (ex: tie-breaking, loading entries, remembering previously loaded folders) to be released when I have free time next, likely early next week.

Afterwards, I was planning on adding new features such as #2 and #3 to v5.1.0 along with the application code signing and notarization which is now required for distributing macOS applications. Currently, I'm leaning towards including this pull request within this second release which I'm hoping to have ready by the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants