Skip to content

template/python.j2: Allow to remove object from object set #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

template/python.j2: Allow to remove object from object set #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/shacl2code/lang/templates/python.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,19 @@ class SHACLObjectSet(object):
self.add_index(obj)
return obj

def remove(self, obj: SHACLObject) -> None:
"""
Remove object from object set

Remove a SHACLObject from the object set and rebuild index.
Copy link
Owner

@JPEWdev JPEWdev Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is fine. Just keep in mind the object might still be in the graph if it's referenced indirectly by another object

Rebuilding the whole index is probably the safest for now; I don't expect this to be a very common operation

"""
if not isinstance(obj, SHACLObject):
raise TypeError("Object is not of type SHACLObject")

if obj in self.objects:
self.objects.remove(obj)
self.create_index()

def update(self, *others) -> None:
"""
Update object set adding all objects in each other iterable
Expand Down
Loading