Improve citation key handling for #12292 #14099
Conversation
- Prioritize 'texkeys' field as citation key if present, and clear it after use - Add post-cleanup logic to detect and replace bad citation keys - Implement texkeys-style citekey generation
Improve INSPIRE citekey handling and cleanup
- Implement retry mechanism with 3 attempts and exponential backoff - Add timeout configuration (10s connect, 30s read) - Add comprehensive logging (INFO/WARN/DEBUG levels) - Add citation key validation to detect URL-like keys - Improve error messages with actionable suggestions - Add test guide for validation Part of issue JabRef#12292 - Task 3.2: INSPIRE API optimization Provides stable data source for other team members' tasks
- Integrated Sonia's 3.1 task (texkeys extraction and key cleanup) - Kept retry mechanism and validation from 3.2 task - Combined both features for complete INSPIRE fetcher improvement - Removed test documentation file
- Import java.time.Duration for timeout settings - Use Duration.ofMillis() for setConnectTimeout (URLDownload only supports connect timeout) - Remove setReadTimeout (not supported by URLDownload class) - Change catch block to ParseException | FetcherException (IOException not thrown) - Code now compiles successfully
feat(3.2): Add retry mechanism and validation to INSPIRE fetcher
Pull from main to branch
…ArXivFetcher in FetchAndMergeEntry.
Generate new citation key on upper stream
Overall this is a well-structured and consistent addition. The new 'Prefer INSPIRE texkeys' option is correctly integrated across the UI, ViewModel, and preferences layers, maintaining JabRef's clean MVVM architecture. The binding logic and persistence flow look solid.
Nice addition! The identifier detection and hint work well. You could slightly improve by throttling detection during typing and maybe tweaking the label’s visibility or color for clarity. Clean and useful update overall.
Junqi compositeidfetcher
Add long citation key detection with user guidance notification.
Hey @SLin417!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
Add logging to WebSearch ViewModels
…etcher duplicates
- Fix uncaught FetcherException in CompositeIdFetcherArxivRouteTest - Fix return type of TestURLDownload.asInputStream() to ProgressInputStream - Add missing import for ProgressInputStream - All 11 tests now pass successfully
test: add identifier detection, OpenAlex parser, INSPIRE texkeys, and Composite arXiv routing tests
|
You committed your code on the For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details. |
|
Your code currently does not meet JabRef's code guidelines. IntelliJ auto format covers some cases. There seem to be issues with your code style and autoformat configuration. Please reformat your code (Ctrl+Alt+L) and commit, then push. In special cases, consider using |
|
Please fix the failing tests. Otherwise we won't review |
7 participants
This PR enhances the citation key generation and reliability of the INSPIRE fetcher. For issue #12292
Key Improvements: