refactor: align contracts with standardized interface traits (#574)#692
Merged
Jagadeeshftw merged 1 commit intoJagadeeshftw:masterfrom Feb 27, 2026
Conversation
|
@Chucks1093 is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
please resolve the conflicts |
Contributor
Author
|
Am working on it |
980193e to
1157f27
Compare
Contributor
Author
|
@Jagadeeshftw merge conflicts have been resolved. Please merge . |
Owner
|
@Chucks1093 Can you please resolve the conflicts? |
- Expanded traits.rs: added PauseInterface and FeeInterface with full doc comments referencing Grainlify internal spec - BountyEscrowContract now formally implements all four traits (EscrowInterface, UpgradeInterface, PauseInterface, FeeInterface) - soroban/contracts/escrow: added local EscrowInterface + UpgradeInterface trait definitions and implementations; added get_balance and get_escrow_info to satisfy standard surface - grainlify-core: added local UpgradeInterface trait and impl for GrainlifyContract (feature-gated to match existing contract gate) - contracts/view-facade: implemented ViewFacade contract with register/deregister/list/get_contract for cross-contract discovery
1157f27 to
8acf9ef
Compare
Contributor
Author
|
@Jagadeeshftw pls merge this |
Contributor
Author
|
@Jagadeeshftw pls review and merge this |
Contributor
Author
|
@Jagadeeshftw please review and merge |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #574
Changes
contracts/bounty_escrow/contracts/escrow/src/traits.rsPauseInterfaceandFeeInterfacealongside existing escrow/upgrade traitsop_lock,op_release,op_refund)contracts/bounty_escrow/contracts/escrow/src/lib.rsBountyEscrowContractnow explicitly implements:EscrowInterfaceUpgradeInterfacePauseInterfaceFeeInterfacesoroban/contracts/escrow/src/lib.rs+soroban/contracts/escrow/src/traits.rsEscrowInterfaceandUpgradeInterfacedefinitions and implementationsget_balanceandget_escrow_infopublic methods to match expected standardized surfacecontracts/grainlify-core/src/lib.rsUpgradeInterfacetrait and implementation forGrainlifyContract"contract"-gated contract patterncontracts/view-facade/src/lib.rs+contracts/view-facade/src/test.rsViewFacadecontract for cross-contract discoveryregister,deregisterlist_contracts,get_contract,contract_countview-facadeAPITesting
contracts/bounty_escrow/contracts/escrowcargo fmt --check --all✅cargo build --release --target wasm32v1-none✅cargo test --verbose --lib✅cargo test --verbose --lib invariant_checker_ci✅contracts/grainlify-corecargo test --lib✅cargo test --lib test::e2e_upgrade_migration_tests -- --nocapture --test-threads=1✅cargo test --lib test::upgrade_rollback_tests -- --nocapture --test-threads=1✅contracts/view-facadecargo test --lib✅Notes
grainlify-interfaces) is introduced later, these local traits can be replaced by re-exports.grainlify-corewere updated to match current implemented migration semantics (same-version migration is rejected by guard checks).