Feat/deterministic batch operation ordering (#553)

[Chucks1093]

Closes #553

Changes

• contracts/bounty_escrow/contracts/escrow/src/lib.rs

  • Added deterministic ordering helpers for batch items:
    • order_batch_lock_items (sort by bounty_id, ascending)
    • order_batch_release_items (sort by bounty_id, ascending)
  • Updated batch_lock_funds and batch_release_funds to process ordered_items instead of caller-provided order.
  • Added explicit # Ordering Guarantee docs to both batch functions.
  • Preserved existing CEI structure and atomic behavior (all-or-nothing semantics unchanged).

• soroban/contracts/program-escrow/src/lib.rs

  • Added deterministic ordering helper:
    • order_batch_registration_items (sort by program_id, ascending)
  • Updated batch_register_programs to run validation, duplicate checks, auth collection, and execution over sorted input.
  • Added # Ordering Guarantee docs to batch_register_programs.

• contracts/bounty_escrow/contracts/escrow/src/test.rs

  • Added test_batch_lock_funds_deterministic_ordering_by_bounty_id
  • Added test_batch_release_funds_deterministic_ordering_by_bounty_id
  • These assert consistent results when caller input is intentionally unsorted.

• soroban/contracts/program-escrow/src/test.rs

  • Added test_batch_register_order_independent_results
  • Verifies that different input orders produce equivalent final state.
  • Also removed an accidental stray prepended test scaffold that was unrelated and causing duplicate-import/undefined-type compile errors.

Deterministic Ordering Guarantee

Batch operations covered in this PR now execute in deterministic, contract-defined order independent of caller input:

• batch_lock_funds -> ascending bounty_id
• batch_release_funds -> ascending bounty_id
• batch_register_programs -> ascending program_id

This reduces input-order ambiguity and improves reproducibility across clients/indexers.

Testing

Executed locally:

• contracts/bounty_escrow/contracts/escrow

  • cargo test --lib -- --nocapture -> 517 passed
  • targeted deterministic ordering tests -> passed

• soroban/contracts/program-escrow

  • cargo test --lib -- --nocapture -> 24 passed
  • targeted order-independence test -> passed

Notes

• contracts/program-escrow (top-level, non-soroban path) currently has pre-existing syntax errors (unclosed/mismatched delimiters) and fails to compile independently; this PR does not modify that crate.
• Scope is intentionally limited to batch entrypoints that compile and are active in the touched modules.

[vercel]

@Chucks1093 is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

[Jagadeeshftw]

please resolve the conflicts

[Chucks1093]

Okay on it

[Chucks1093]

@Jagadeeshftw can you quickly merge?

[Jagadeeshftw]

@Chucks1093 Can you please resolve the conflicts?

[Chucks1093]

@Jagadeeshftw please review and merge