This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Animators defined in XMLs should work with Build Tools 22#81
Open
serso wants to merge 1 commit intoJakeWharton:masterfrom
Open
Animators defined in XMLs should work with Build Tools 22#81serso wants to merge 1 commit intoJakeWharton:masterfrom
serso wants to merge 1 commit intoJakeWharton:masterfrom
Conversation
Problem: Build Tools 22 removes attributes targeted to higher versions of Android from xml file, copying the original file to an appropriate bucket. On lower versions of Android (f.e. 9) NineOldAndroids can't access such attributes (as they are now in animator-vXX bucket) and crashes. Solution: let's use our own custom attributes instead of Android attributes. All XMLs defining animators should be changed - project namespace should be used instead of Android one. Fixes JakeWharton#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Build Tools 22 removes attributes targeted to higher
versions of Android from xml file, copying the original
file to an appropriate bucket. On lower versions of
Android (f.e. 9) NineOldAndroids can't access such
attributes (as they are now in animator-vXX bucket) and crashes.
Solution: let's use our own custom attributes instead of
Android attributes. All XMLs defining animators should be changed -
project namespace should be used instead of Android one.
Fixes #80