This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Always add maven support repository#35
Open
stormbeta wants to merge 1 commit intoJakeWharton:masterfrom
Open
Conversation
Repositories need to be added before dependencies are declared Otherwise those dependencies won't be resolved against a freshly downloaded m2 support repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the m2 support repo is added after dependencies are declared, then the dependencies won't resolve. This isn't an issue if the repo already exists, as Google's android gradle plugin takes care of it, but if it needed to be downloaded, this will cause the first fresh build to fail.
I modified the plugin to always add the m2 support repo instead. If it's not needed (and thus doesn't exist), it shouldn't hurt anything as gradle will simply treat it as an empty repository.