This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Always update Platform Tools and SDK Tools.#37
Open
abic wants to merge 2 commits intoJakeWharton:masterfrom
Open
Always update Platform Tools and SDK Tools.#37abic wants to merge 2 commits intoJakeWharton:masterfrom
abic wants to merge 2 commits intoJakeWharton:masterfrom
Conversation
Author
|
Probably should actually look to see that there are updates... |
Owner
|
Yes this is wasteful. Only things that are missing should be downloaded. |
This means that the packages won't be downloaded if they're already up-to-date.
Contributor
|
@abic Can you rebase so @JakeWharton can get this in? |
Contributor
FYI, my PR #111 actually does this and checks whether the latest available version of the SDK tools is greater than the installed version before calling update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with the recent bump of the downloaded sdk version, CI systems that cache the sdk still won't be updated. This change is to ensure platform-tools and sdk tools are always up-to-date.