This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Open
Conversation
Perfoms dependency tree scan to find if any of the top level dependencies listed at the build.gradle file depends on support library and though android m2repository needs to be downloaded. NOTE: establishing network connection and downloading dependency pom are required to analyze if dependency has childrens. Implementation is inspired by official gradle "dependency" task which prints dependency tree https://github.com/gradle/gradle/blob/master/subprojects/diagnostics/src/main/groovy/org/gradle/api/tasks/diagnostics/AbstractDependencyReportTask.java#L58
Author
There was a problem hiding this comment.
I have moved adding android repository url above dependency scan routine.
This is necessary because now we are not just parsing strings at the build.gradle file, but gradle actually tries to resolve dependencies. And to be able to resolve the "up-to-date" case gradle needs m2repository link to resolve support library if it's repository is present.
Author
|
Same thing could be done for play-services check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfoms dependency tree scan to find if any of the top level
dependencies listed at the build.gradle file depends on support
library and though android m2repository needs to be downloaded.
NOTE: establishing network connection and downloading dependency pom
are required to analyze if dependency has childrens.
Implementation is inspired by official gradle "dependency" task
which prints dependency tree
https://github.com/gradle/gradle/blob/master/subprojects/diagnostics/src/main/groovy/org/gradle/api/tasks/diagnostics/AbstractDependencyReportTask.java#L58