Normalize macOS Delete code (8) to the 46 which Windows/Unix uses #3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a small thing, but on a mac laptop, the delete button sends keycode 8. But all the delete shortcuts are tied to 46.
Rather than adjust the shortcuts based on whether it is mac or windows (easy enough for desktop, but harder for the webapp), I just normalize every keycode 8 into 46, because there are no shortcuts bound to 8.
summary of the weird macOS/windows keycode issue.
Without this PR, the workaround is that whenever a shortcut says
Delete, it is actuallyFn+Delete.