New IDP class and new distribution methods for generating links #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new ImportedDataProject class and 2 new distribution methods for generating unique links.
Imported Data Project class includes these new methods.
New methods on Distributions class:
Major, potentially breaking change! variable path added to returned URL for xm=True when calling self.header_setup() method. This seems to make sense for consistency rather than adding the path manually after generating the directory base url - the path parameter should be able to be combined as well. I don't think this breaks any of the existing directory methods, but it could have consequences in methods I didn't test.