This repository was archived by the owner on May 1, 2018. It is now read-only.
fix warning when using group on form-horizontal#5
Open
donnykurnia wants to merge 1 commit intoJasonKaz:3.xfrom
Open
fix warning when using group on form-horizontal#5donnykurnia wants to merge 1 commit intoJasonKaz:3.xfrom
donnykurnia wants to merge 1 commit intoJasonKaz:3.xfrom
Conversation
`get_class` should only check the `$Args[1]`.
Found the bug in the example, using form-horizontal for the file field will generate warning because `$Args[$i]` when `$i === $ArgCount - 1` is a string (`"Help Text"`):
$Form->group($Form->label('File'), new \JasonKaz\FormBuild\File(), "Help Text");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_classshould only check the$Args[1].Found the bug in the example, using form-horizontal for the file field will generate warning because
$Args[$i]when$i === $ArgCount - 1is a string ("Help Text"):