Skip to content

Converted to static library. Eliminated Unnecessary files. Updated imports. Shared schemes.#10

Open
mralexgray wants to merge 1 commit intoJensAyton:hairyfrom
mralexgray:static-lib
Open

Converted to static library. Eliminated Unnecessary files. Updated imports. Shared schemes.#10
mralexgray wants to merge 1 commit intoJensAyton:hairyfrom
mralexgray:static-lib

Conversation

@mralexgray
Copy link

All tests pass except 2... are they meant to fail?

-[JATemplateTests testMissingSubstitution] failed Group
-[JATemplateTests testLocalization] failed Group 

Test app output with nothing but a link to static lib...

Trivial string
foo: sausage; bar: 76
JATemplate warning: Template substitution uses unknown parameter "nonesuch". (Template: "Unknown variable: {nonesuch}")
Unknown variable: {nonesuch}
Fancy bar: Seventy-Six
The sum of 76 and 30 is 106.
Boolean: false
File bytes: 66 KB; memory bytes: 64 KB
I have one kitten. You have three kittens. I have seven geese. You have one goose.
Today is Friday.
Fold operator: blaa
Braces: int main() { return 0; }
A rect: {{100, 200}, {400, 400}}
This is a template from Localizable.strings, not the one in the source code.
This is a localized template expanded in SUPER EXCITING! mode.
Debug description: <__NSArrayI 0x600000048910>(
foo,
36,
1
)

@JensAyton
Copy link
Owner

testLocalization is failing because you removed the command line argument -AppleLocale en_US in the JATemplate scheme, which is necessary for the localization test to run in a uniform environment.

testMissingSubstitution is failing because building as a library breaks the mechanism of overriding JATReportWarning through a macro (in JATemplateTest-Prefix.pch). If you want to build it this way, a more robust dependency injection mechanism is needed (e.g. a JATSetReportWarningFunction() function).

The patch is not buildable, because you removed JATemplate-Prefix.pch but left references to it in the project.

I’d prefer to see a patch like this done against the master (Vanilla) branch, so I can merge it into Hairy; I always merge changes to both variants in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants