Skip to content

Wrap Icon in TopMenuButtonImpl in a TooltipBox to be able to show a tooltip for Toolbar menu items #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Wrap Icon in TopMenuButtonImpl in a TooltipBox to be able to show a tooltip for Toolbar menu items #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/TopMenuButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.selection.toggleable
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
import androidx.compose.material3.PlainTooltip
import androidx.compose.material3.TooltipBox
import androidx.compose.material3.TooltipDefaults
import androidx.compose.material3.rememberTooltipState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
Expand All @@ -29,6 +34,7 @@ import org.jetbrains.compose.ui.tooling.preview.Preview
import org.jetbrains.kotlinconf.ui.theme.KotlinConfTheme
import org.jetbrains.kotlinconf.ui.theme.PreviewHelper

@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun TopMenuButtonImpl(
icon: DrawableResource,
Expand All @@ -38,18 +44,24 @@ private fun TopMenuButtonImpl(
iconColor: Color,
modifier: Modifier = Modifier,
) {
Icon(
modifier = modifier
.padding(6.dp)
.size(36.dp)
.clip(CircleShape)
.then(interactionModifier)
.background(backgroundColor)
.padding(6.dp),
painter = painterResource(icon),
contentDescription = contentDescription,
tint = iconColor,
)
TooltipBox(
positionProvider = TooltipDefaults.rememberPlainTooltipPositionProvider(),
tooltip = { PlainTooltip { Text(contentDescription) } },
state = rememberTooltipState()
) {
Icon(
modifier = modifier
.padding(6.dp)
.size(36.dp)
.clip(CircleShape)
.then(interactionModifier)
.background(backgroundColor)
.padding(6.dp),
painter = painterResource(icon),
contentDescription = contentDescription,
tint = iconColor,
)
}
}

/**
Expand Down