Commented out mysql_free_result function calls to resolve issue #2 re… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I’ve done a quick workaround for issue #2 (and unintentionally #3 as well) in the branch named “issue_2_php7_compat” in my fork. As you know, this is a particularly insidious bug that has affected a lot of our user base using WHMCS 7 and PHP 7 and is only coming up because their DB compat layer doesn't emulate mysql_free_result(). I think it’d be worthwhile to pull it into the project repository in order to get it into the next release of CSF Manager.
In the long term, rewriting the MySQL functionality to use Capsule as provided by WHMCS is the ideal solution, but this gets the addon working for now.
Thanks!
Lawrence