fixes #287 Unable to stop the camera when route changed

[Patrick-Sherlund]

There is an issue in the following scenario:

1. QrReader Component is initially mounted on render
2. User navigates to another component (i.e. via React Router, without reloading page)
3. Component is unmounted, but the camera continues to run in the background, even though the component was unmounted. Decode function from @zxing runs independently of any video source and does not stop.

Now, Upon unmounting of the QrReader component, the video track will be stopped and parent decode functions will be haulted.

[Patrick-Sherlund]

@JodusNodus @JonatanSalas Please review and let me know if there are any issues! Thank you

[uptownben]

Any chance this can get merged in? Deal breaker for my use case.

[ballafonte]

I have found that throwing an Exception here is unnecessary and undesirable as it leads to an uncaught runtime error. We can also stop the code reader using controls:

    if (isValidType(video, 'constraints', 'object')) {
      codeReader
-       .decodeFromConstraints({video}, videoId, (result, error) => {
+       .decodeFromConstraints({video}, videoId, (result, error, controls) => {
          if (stopRequested.current) {
-           //Callback to parent function continuously runs after destruction of Video Element // Stream Video Tracks
-           //Intentionally throwing exception to step out of parent function.
-           throw new StopRequestedException();
+           controls?.stop();
          }
          if (isValidType(onResult, 'onResult', 'function')) {
            onResult?.(result, error, codeReader);
          }
        })
        .then((controls: IScannerControls) => (controlsRef.current = controls))
        .catch((error: Error) => {
          if (isValidType(onResult, 'onResult', 'function')) {
            onResult?.(null, error, codeReader);
          }
        });
    }

[ballafonte]

We can remove this class if we use controls instead of throwing an exception

[ballafonte]

This causes an error when QrReader is conditionally rendered, because when QrReader is unmounted, no media can be found. We can handle it:

        navigator.mediaDevices
          .getUserMedia({
            video: true,
            audio: false,
          })
          .then((mediaStream) =>
            mediaStream.getTracks().forEach((track) => {
              track.stop();
              mediaStream.removeTrack(track);
            })
          )
+         .catch((error) => {
+           console.warn('Error stopping video tracks:', error);
+         });

[adboio]

is this going to be merged?