fix: Update product type fields for consistency in product templates

feat: Add XML validation script for product data integrity
refactor: Change string formatting style in map_display method

Author: odoo

records_management/data/products.xml

@@ -4,7 +4,7 @@
         <!-- Product Template for Document Storage Box -->
         <record id="product_template_box" model="product.template">
             <field name="name">Document Storage Box</field>
-            <field name="detailed_type">product</field>
+            <field name="type">product</field>
             <field name="categ_id" ref="product.product_category_all"/>
             <field name="default_code">REC-BOX</field>
             <field name="list_price">15.00</field>
@@ -27,8 +27,7 @@
         <!-- Product Template for Document File -->
         <record id="product_template_file" model="product.template">
             <field name="name">Document File</field>
-            <field name="detailed_type">product</field>
-            <field name="tracking">serial</field>
+            <field name="type">product</field>
             <field name="categ_id" ref="product.product_category_all"/>
             <field name="default_code">REC-FILE</field>
             <field name="list_price">5.00</field>
@@ -51,7 +50,7 @@
         <!-- Storage Service Product -->
         <record id="product_template_storage_service" model="product.template">
             <field name="name">Document Storage Service</field>
-            <field name="detailed_type">service</field>
+            <field name="type">service</field>
             <field name="categ_id" ref="product.product_category_all"/>
             <field name="default_code">REC-STOR-SVC</field>
             <field name="list_price">25.00</field>
@@ -72,7 +71,7 @@
         <!-- Shredding Service Product -->
         <record id="product_template_shredding_service" model="product.template">
             <field name="name">Document Shredding Service</field>
-            <field name="detailed_type">service</field>
+            <field name="type">service</field>
             <field name="categ_id" ref="product.product_category_all"/>
             <field name="default_code">REC-SHRED-SVC</field>
             <field name="list_price">50.00</field>

records_management/data/scheduled_actions.xml

@@ -3,7 +3,7 @@
     <data noupdate="1">
         <record id="ir_cron_compute_monthly_storage_fees" model="ir.cron">
             <field name="name">Compute Monthly Storage Fees</field>
-            <field name="model_id" ref="model_stock_quant"/>
+            <field name="model_id" ref="stock.model_stock_quant"/>
             <field name="state">code</field>
             <field name="code">
 # Import defaultdict to aggregate quantities per customer
@@ -39,17 +39,17 @@ try:
                     'order_line': [(0, 0, {
                         'product_id': product.id,
                         'product_uom_qty': qty,
-                        'name': f'Monthly Storage Fee for {qty} items',
+                        'name': 'Monthly Storage Fee for %s items' % qty,
                     })],
                 })
 except Exception as e:
-    _logger.error(f'Error computing monthly storage fees: {str(e)}')
+    _logger.error('Error computing monthly storage fees: %s' % str(e))
 </field>
             <field name="numbercall">-1</field>
             <field name="active">True</field>
             <field name="interval_number">1</field>
             <field name="interval_type">months</field>
-            <field name="nextcall" eval="(DateTime.now() + relativedelta(months=1)).strftime('%Y-%m-%d 00:00:00')"/>
+            <field name="nextcall" eval="(datetime.now() + relativedelta(months=1)).strftime('%Y-%m-%d 00:00:00')"/>
         </record>
     </data>
 </odoo>

records_management/models/shredding_service.py

@@ -55,6 +55,6 @@ def _compute_total_charge(self):
     def _compute_map_display(self):
         for record in self:
             if record.latitude and record.longitude:
-                record.map_display = f"{record.latitude},{record.longitude}"
+                record.map_display = "%s,%s" % (record.latitude, record.longitude)
             else:
                 record.map_display = ''

validate_xml.py

@@ -0,0 +1,21 @@
+#!/usr/bin/env python3
+import xml.etree.ElementTree as ET
+import sys
+
+def validate_xml(file_path):
+    try:
+        tree = ET.parse(file_path)
+        print(f'✅ {file_path} is valid XML')
+        return True
+    except ET.ParseError as e:
+        print(f'❌ {file_path} - XML Parse Error: {e}')
+        return False
+    except Exception as e:
+        print(f'❌ {file_path} - Error: {e}')
+        return False
+
+# Validate products.xml
+if validate_xml('records_management/data/products.xml'):
+    print('Products XML is ready for deployment!')
+else:
+    sys.exit(1)