This repository was archived by the owner on May 13, 2022. It is now read-only.
Alternative Bitcoin Core integration#565
Open
veqtrus wants to merge 3 commits intoJoinMarket-Org:developfrom
Open
Alternative Bitcoin Core integration#565veqtrus wants to merge 3 commits intoJoinMarket-Org:developfrom
veqtrus wants to merge 3 commits intoJoinMarket-Org:developfrom
Conversation
`str` and `unicode` inherit `basestring`
Default to `estimate_tx_fee` from wallet.py
Bitcoin Core integration
Collaborator
|
Really we developers should be talking to each other more so work like this isn't repeated. |
Contributor
Author
|
I did discuss this on IRC 7 days ago and waxwing told me you were working on it but... |
97d2603 to
47479d5
Compare
Contributor
|
What was the main goal of this change? What do we still need from it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently @chris-belcher has been working on something similar in #555 but I had this ready before I noticed the PR so here it is.