Skip to content

Conversation

@vaughansharman
Copy link

Thanks for creating this tool. I was using this yesterday and ran into a couple of issues running on an M2

  1. The npz folder was not being passed in correctly (see dummy in diff)
  2. The device was not being set properly when resorting to CPU

There may of course be better ways to achieve the fixes, so feel free to suggest improvements

@JonathanFly
Copy link
Owner

Thanks. I'm gonna integrate this manually because I'm wary of changing the original generation.py bark code too much. I may ask you to test on a mac for me, since I don't have one.

@vaughansharman
Copy link
Author

Thanks. I'm gonna integrate this manually because I'm wary of changing the original generation.py bark code too much. I may ask you to test on a mac for me, since I don't have one.

Yeah, no worries, just let me know when it's ready to test, cheers!

@JonathanFly
Copy link
Owner

I think I did put these changes in, but I honestly completely lost track and I think I probably broke MPS with a bunch more changes I added for AMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants