added orderby for each query #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanakram3
approved these changes
Oct 21, 2022
Contributor
zeeshanakram3
left a comment
zeeshanakram3
left a comment
There was a problem hiding this comment.
LGTM. Sorry for a late review and thanks for the fix @mkbeefcake
Member
|
@zeeshanakram3 This looks useful? Should we merge and include in next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happened in SQL query with "union".
The subqueries didn't contain orderby tags inside it, so it happened.
https://discord.com/channels/811216481340751934/812344874099277824/1026519654006542427
Joystream/pioneer#3125
so i added orderby to each SQL query