You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gdalle Added an interesting application here as a test case. We form a taylor approximation of an ExaModels ACOPF (here, at the locally optimal solution found by Ipopt) then solve it with CoolPDLP. It's pretty heavy so might be better to simplify for the sake of CI time before merging though.
The extension is a good idea but I don't see why the power model application belongs in our test suite. It's very specific and adds several dependencies that would otherwise not be needed. Can we limit ourselves to checking the correctness of the conversion, since that is the only thing added to the source code?
The source code doesn't do any linearization, it should be the same exact mathematical model, just different wrapper types. I'm not opposed to removing the ignore_islp to just always error if there are any quadratic terms. Then with #28 we can remove the check entirely.
The reason will be displayed to describe this comment to others. Learn more.
Accessing private fields is generally considered an antipattern in Julia. Besides, the try/catch might lead to type instability. I think we better handle it via dispatch (but I'm not sure how).
As a first step, we might allow At to have a different type than A. In the setting where the user provides two linear operators (lazy matrix-vector products), they have no reason to share the same type anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #30
To allow us to solve models coming from ExaModels, ADNLPModels, etc.