edge case: tril!, triu! and I constructors with empty matrices
#642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/testsuite/construction.jl b/test/testsuite/construction.jl
index 0ed3393..482e47c 100644
--- a/test/testsuite/construction.jl
+++ b/test/testsuite/construction.jl
@@ -193,7 +193,7 @@
x1 = AT{Float32, 2}(I, (0, 3))
@test Array(x1) ≈ x
-
+
copyto!(x1, I)
@test Array(x1) ≈ x
end |
maleadt
requested changes
Oct 28, 2025
|
Thanks for the review! @maleadt |
| d in -2:2 | ||
| A = randn(Float32, 10, 10) | ||
| @test f(A, d) == Array(f!(AT(A), d)) | ||
| @test compare(f, AT, A) |
There was a problem hiding this comment.
Suggested change
| @test compare(f, AT, A) | |
| @test compare(f, AT, A, d) |
| @test compare(f, AT, A) | ||
|
|
||
| A_empty = randn(Float32, 0, 0) | ||
| @test compare(f, AT, A_empty) |
There was a problem hiding this comment.
Suggested change
| @test compare(f, AT, A_empty) | |
| @test compare(f, AT, A_empty, d) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcuts the kernels in
triu!,tril!andidentity_kernelif the arguments are empty matrices.All three would fail with
DivideError: integer division error(from KernelAbstractions.jl).