Skip to content

fix issue #58; set initial n to min. points #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue #58; set initial n to min. points #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c9b681
fix issue #58; set initial `n` to min. points
manuelbb-upb Oct 15, 2025
8e058c5
remove debug @show statement
manuelbb-upb Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Dierckx.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,10 @@ function _ParametricSpline(u::Union{AbstractVector, Nothing}, x::AbstractMatrix,

xin = convert(Matrix{Float64}, x)
win = convert(Vector{Float64}, w)
n = Ref{Int32}(nest)
n = Ref{Int32}(periodic ? 2k + 2 : nest)
# NOTE if `periodic==true`, intial `n` has to be minimum number of knots needed for
# constant interpolation due to a bug in Fortran source file `fpclos.f`
# this should resolve `https://github.com/JuliaMath/Dierckx.jl/issues/58
c = Vector{Float64}(undef, idim*nest)
fp = Ref{Float64}(0)
ier = Ref{Int32}(0)
Expand Down Expand Up @@ -633,7 +636,6 @@ function _ParametricSpline(u::Union{AbstractVector, Nothing}, x::AbstractMatrix,
ier::Ref{Int32},
)::Nothing
end

ier[] <= 0 || error(_fit1d_messages[ier[]])

resize!(t, n[])
Expand Down
Loading