Skip to content

Conversation

@MonssafToukal
Copy link

No description provided.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to also add a sample benchmarks.jl file that creates a const SUITE = BenchmarkGroup() ?

@MonssafToukal MonssafToukal force-pushed the main branch 2 times, most recently from 474f8e0 to 394e7e8 Compare October 26, 2021 23:22
* adding/updating file: push_benchmarks.sh

* adding/updating file: benchmark/run_benchmarks.jl

* adding/updating file: benchmark/send_comment_to_pr.jl

* adding/updating file: Jenkinsfile

* setting up project.toml for benchmarks

* Add token to jenkinsfile

authored-by: Monssaf Toukal <tmonssaf@gmail.com>
@MonssafToukal MonssafToukal force-pushed the main branch 2 times, most recently from 4854992 to 55aed9e Compare October 26, 2021 23:39
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main directory, you can also add benchmark/Manifest.toml in the .gitignore file.

Git = "d7ba0133-e1db-5d97-8f8c-041e4b3a1eb2"
GitHub = "bc5e4493-9b4d-5f90-b8aa-2b2bcaad7a26"
JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In DCISolver.jl, we also had DCISolver in the dependencies here. So, I guess JSOTemplate should also.

@dpo
Copy link
Member

dpo commented Oct 29, 2021

I also suggest

  • adding a README.md to the benchmark folder to guide the user and document the form of the SUITE variable;
  • adding a module_benchmark.jl script that can be customize to compare against another package (instead of comparing two commits).

@MonssafToukal MonssafToukal marked this pull request as draft November 3, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants