-
Notifications
You must be signed in to change notification settings - Fork 9
solver benchmark: specifying solver-specific options
#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnavk23
wants to merge
3
commits into
JuliaSmoothOptimizers:main
Choose a base branch
from
arnavk23:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -221,3 +221,33 @@ p = profile_solvers(stats, costs, costnames) | |
| Here is a useful tutorial on how to use the benchmark with specific solver: | ||
| [Run a benchmark with OptimizationProblems](https://jso.dev/OptimizationProblems.jl/dev/benchmark/) | ||
| The tutorial covers how to use the problems from `OptimizationProblems` to run a benchmark for unconstrained optimization. | ||
|
|
||
| ### Handling `solver_specific` in stats | ||
| If a solver's GenericExecutionStats contains a `solver_specific` dictionary | ||
| , a column is created for | ||
| each key in that dictionary in the per-solver `DataFrame`. | ||
|
|
||
| Here is a example showing how to set a solver-specific flag and then access it for tabulation: | ||
| ```julia | ||
| using NLPModelsTest, DataFrames, SolverCore, SolverBenchmark | ||
|
|
||
| function newton(nlp) | ||
| stats = GenericExecutionStats(nlp) | ||
| set_solver_specific!(stats, :isConvex, true) | ||
| return stats | ||
| end | ||
|
|
||
| solvers = Dict(:newton => newton) | ||
| problems = [NLPModelsTest.BROWNDEN()] | ||
| stats = bmark_solvers(solvers, problems) | ||
|
|
||
| combined_stats = DataFrame( | ||
| name = stats[:newton].name, | ||
| nvars = stats[:newton].nvar, | ||
| convex = stats[:newton].isConvex, | ||
| newton_iters = stats[:newton].iter, | ||
| ) | ||
|
|
||
| combined_stats.convex = string.(combined_stats.convex) | ||
| pretty_stats(combined_stats) | ||
|
Comment on lines
+243
to
+252
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you need all this? Isn't the result of bmark_solvers sufficient ? |
||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense. It's the Project.toml in the same folder of index.jmd that should be updated