Fix item teleports flyout anchor #173
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
So if I understand correctly, you're fixing something he broke in his PR? (as this was how it is right now, I did see that part changed and wondered why). |
Author
|
Nope, it so happens that this part was changed later and needed to be done as well to fix the bug. |
Owner
|
I tried this locally and I don't see why this is needed, can you provide a before and after screenshot of what you are seeing? |
Author
|
Yeah sure. Here's current behavior: 
Here's with 40bf39c applied: 
And here's with this PR applied on top of it: 
Here's right side for comparison: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on changes made in #163.