Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some infrastructure to be able to hook into creating initial vectors for
eigsolve.This came up in #126.
I've added an overloadable
eigsolve_initfunction that can be used instead.Unfortunately, in order to make this backwards compatible this gets a bit messy with the multitude of different signatures that
eigsolveneeds to support.For example, I'm not sure if it is that useful to support signatures with
nto specify the size of the matrix. Replacing this withrand(T, n)would not really be that much more verbose, and would make dispatching a bit easier.Considering the initialization of the sparse eigenvectors, I don't know enough about this topic to make an educated choice.
Is defaulting to dense vectors the correct way to characterize random eigenvectors? Should these be random sparse vectors with some specified sparsity instead?
Do we instead force users to provide a starting vector, or throw a warning?