Skip to content

Antenna Targeting UX Improvements#67

Merged
DRVeyl merged 12 commits intoKSP-RO:masterfrom
Clayell:master
Feb 17, 2026
Merged

Antenna Targeting UX Improvements#67
DRVeyl merged 12 commits intoKSP-RO:masterfrom
Clayell:master

Conversation

@Clayell
Copy link
Copy Markdown

@Clayell Clayell commented Feb 14, 2026

image

Additionally, fix bug where the targetMode could be set to an invalid mode the first time that the menu is opened
(for some reason this causes a harmless InvalidCastException in the Vector2 scroll view when it activates. GUI is weird)

Additionally, remove log spam from AntennaTarget.Awake()
(would get logged every time a target changed, which is just excessive)
image

Comment thread src/RealAntennasProject/Targeting/AntennaTarget.cs Outdated
@siimav
Copy link
Copy Markdown

siimav commented Feb 16, 2026

If you feel like using the word "Additionally" then it should be a separate PR.

Comment thread src/RealAntennasProject/Targeting/AntennaTargetGUI.cs Outdated
Comment thread src/RealAntennasProject/Targeting/AntennaTargetGUI.cs Outdated
@DRVeyl
Copy link
Copy Markdown

DRVeyl commented Feb 16, 2026

I don't know why 10 digits is at all sane for these fields. I can see why "4" is 1 too few.

@Clayell
Copy link
Copy Markdown
Author

Clayell commented Feb 16, 2026

I don't know why 10 digits is at all sane for these fields. I can see why "4" is 1 too few.

I would argue that more precision is better if the user wants it. 10 digits doesn't seem to break any of the UIs.
image
image
image
(deflection doesn't seem to use all of the digits because of the extra things it does)

@DRVeyl
Copy link
Copy Markdown

DRVeyl commented Feb 16, 2026

Sounds like 20 digits is the go-to! You can always make the UI bigger.
No, I don't think any-amount-of-precision is good UI or good UX. And "it doesn't break the UI" is not a good criterion. IMO you shouldn't have, or be asked to use, an amount that is more than gives you the functionality needed.
2 decimals latitude (0.01 degrees) on Earth is what, ~1 km?

Comment thread src/RealAntennasProject/Targeting/AntennaTargetGUI.cs Outdated
@Clayell
Copy link
Copy Markdown
Author

Clayell commented Feb 16, 2026

2 decimals latitude (0.01 degrees) on Earth is what, ~1 km?

Ok, that would require 6 characters for negative numbers though. -70.01. The original complaint was how 4 characters only allowed something like -70.. 6 characters seems fine I suppose. I'll do 7 for deflection to match the original code. (since it can have something in the hundreds place)

Comment thread src/RealAntennasProject/Targeting/AntennaTargetGUI.cs Outdated
@Clayell Clayell changed the title Increase text field length in targeting menu to 10 characters Increase text field length in targeting menu to 6 characters, fix invalid mode on low level antennas, fix AntennaTarget.Awake() spam Feb 16, 2026
@DRVeyl DRVeyl merged commit db2c918 into KSP-RO:master Feb 17, 2026
3 checks passed
@DRVeyl DRVeyl changed the title Increase text field length in targeting menu to 6 characters, fix invalid mode on low level antennas, fix AntennaTarget.Awake() spam Antenna Targeting UX Improvements Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants