isHome =/= is a ground station, add eventvoid hook to signal when the network updates#70
Open
periodically-makes-puns wants to merge 2 commits intoKSP-RO:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for Skopos, and the hook needed for mockingbirdnest/Skopos#70.
This formally distinguishes between "ground stations" and "homes". Checks that appear to apply to all ground stations (and not just "homes") now check the
isGroundStationflag, which checks ifParentBodyis not null.Two non-trivial usages of
CommNode.isHomeare currently left unmodified:RealAntenna.LoadFromConfigNode: I am not confident that the ParentNode is fully initialised when we call this function.RATools.HighestGainCompatibleDSNAntenna: The function name appears to imply it is intended for "home" antennas, though it is currently unused in the code (?).I don't think replacing the
isHomeusages inPhysics.csactually changed any calculations? When I checked a link with low antenna elevation and high beamwidth (GEO sat to Bering Sea ship), it had no impact on the calculated noise temperature.