feat: full runtime implementation + Lua-driven UI#16
Conversation
…, and Lua-driven UI Replace all SDK logging stubs with functional implementations so recompiled GameCube binaries can actually boot and run. OS/SDK Foundation: - Arena heap allocator (lo/hi cursors in GC address space) - Timebase timer (40.5 MHz), interrupt system (32 slots) - OSInit, OSReport, OSFatal and SDK dispatch routing GX Graphics Engine: - Full GX state machine (21 vertex attrs, 16 TEV stages, matrices, blend/Z/cull/scissor/viewport, lighting channels) - Vertex accumulator with GXBegin/GXEnd and auto-flush draw lists - Dynamic WGSL fragment shader generation from TEV configuration - wgpu render pipeline cache keyed on GX state hash - EFB at native 640x480 with depth buffer and upscaling Video Interface: - NTSC/PAL mode support, VBlank timing, retrace callbacks Audio System: - Audio Interface with DMA, Nintendo DSP-ADPCM decoder (64 voices) - Stereo mixer with resampling, cpal output thread Lua-Driven UI: - Expanded widget system (14 types with callbacks, styles, children) - 7 Lua screen definitions (main menu, FPS, graphics, audio, controller config, game settings) - Callback registry with thread-safe string-based function lookup - Full Iced rendering of all Lua widget types Game Boot Loop: - winit 0.30 ApplicationHandler with window creation and ESC menu toggle - SDK init sequence, CPU context setup, DOL section loading Bug Fixes: - CMPR/DXT1 texture decoder with correct 8x8 macro-tile Z-order layout - All 8 texture formats now use correct GC tile-based iteration - LRU texture cache with proper VecDeque access-order tracking - Memory mapper: removed ARAM overlap, added uncached mirror and HW regs - DMA execute_transfer with actual RAM/ARAM byte copying - Controller profile round-trip serialization with typed structs - Resolved all clippy warnings across entire workspace (70+) - Bumped MSRV to 1.80 (LazyLock usage)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 31
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
| WindowEvent::Resized(size) => { | ||
| if let Some(renderer) = runtime.renderer_mut() { | ||
| renderer.resize(size.width, size.height); |
There was a problem hiding this comment.
Missing zero-size guard causes wgpu panic on minimize
High Severity
The WindowEvent::Resized handler passes size.width and size.height directly to renderer.resize(), which sets them on the wgpu SurfaceConfiguration and calls surface.configure(). wgpu requires non-zero dimensions — when the window is minimized (common on Windows), winit delivers a Resized event with (0, 0), causing a panic inside wgpu. A guard like if size.width > 0 && size.height > 0 is needed before calling resize.
1 participant
Summary
ApplicationHandlerwith ESC menu toggle, SDK init sequence, CPU context setup94 files changed, +8254 / -2772 lines across all 7 workspace crates + Lua UI definitions.
Test plan
cargo build --workspacecompiles cleanlycargo clippy --all-targets --all-features -- -D warnings— zero warningscargo test --all --lib --bins— 34 tests pass (3 core + 31 runtime)cargo fmt --all -- --check— cleangamebinary, verify window opens and Lua UI screens renderNote
Medium Risk
Moderate risk: replaces the
gamebinary entrypoint with a real event loop and runtime initialization (graphics/audio/update), which can introduce startup and platform-specific windowing issues; other changes are mostly MSRV/dependency updates and clippy-driven refactors.Overview
Replaces the placeholder
gameentrypoint with a full runtime bootstrap. The newGameAppruns awinitApplicationHandlerloop, initializes the SDK/CPU context, creates a window, brings upgcrecomp-runtimegraphics (and optional audio), handles resize/redraw, and toggles a menu flag onEsc.Adds startup Lua loading for UI and game scripts (
lua/ui/init.lua,lua/game/init.lua) plus logging viaenv_logger, and updatesgamedependencies accordingly.Maintenance/clippy cleanup and toolchain bump: raises clippy MSRV to Rust 1.80, marks unused CLI/output helpers and codegen fields as underscore-prefixed, and applies small refactors/formatting in recompiler analysis/codegen to keep builds warning-free.
Written by Cursor Bugbot for commit b2190e8. This will update automatically on new commits. Configure here.