Update default_validator; add custom error when user output is empty#283
Merged
pehrsoderman merged 2 commits intoKattis:developfrom Mar 3, 2025
Conversation
gkreitz
approved these changes
Mar 3, 2025
Contributor
gkreitz
left a comment
There was a problem hiding this comment.
Thanks, looks good!
I suggested one minor change to a message. Happy to merge this as-is too (if you prefer the current message, or if I my suggested phrasing is incorrect).
pehrsoderman
approved these changes
Mar 3, 2025
bc441fe to
71bdda4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user output file is completely empty, add the error message "user output was empty"; when the user output file contains only whitespace, add the error message "user output contained no tokens".
Other changes:
if (...) stmt;asif (...) { stmt; }judgeans_posandstdin_pos(line 17). Previously, they were implicitly initialized to zero (since they are global variables).judgeans_lineandstdin_lineto1(line 18). Previously, they were set to1inmain(), before thewhile (true)loop.