Skip to content

Only do multithread compilation of submissions actually used by -s #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkreitz merged 2 commits into from
Jan 16, 2026
Merged

Only do multithread compilation of submissions actually used by -s #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17a364
Only compile multithread compile submissions actually used by -s
Matistjati Jan 10, 2026
77128aa
Add back multithreaded output validator compilation
Matistjati Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions problemtools/verifyproblem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1854,9 +1854,12 @@ def start_background_work(self, context: Context) -> None:
# Send off an early background compile job for each submission and
# validator, to avoid a bottleneck step at the start of each test run.
self.problem.output_validators.start_background_work(context)
Copy link
Contributor

@gkreitz gkreitz Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't have been intentional to remove this line (compiling the output validator), right?

Copy link
Contributor Author

@Matistjati Matistjati Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, reverted.

for acr in self._submissions:
for verdict in Submissions._VERDICTS:
acr = verdict[0]
for sub in self._submissions[acr]:
context.submit_background_work(lambda s: s.compile(), sub)
sub_name = sub.name # type: ignore
if context.submission_filter.search(os.path.join(verdict[1], sub_name)):
context.submit_background_work(lambda s: s.compile(), sub)

def _compute_time_limit(self, fixed_limit: float | None, lower_bound_runtime: float | None) -> tuple[float, float]:
if fixed_limit is None and lower_bound_runtime is None:
Expand Down