Improved getting topic data in element props.data only for subscribed topics.#14
Open
nmengers wants to merge 7 commits intoKeKs0r:release_workflowfrom
Open
Improved getting topic data in element props.data only for subscribed topics.#14nmengers wants to merge 7 commits intoKeKs0r:release_workflowfrom
nmengers wants to merge 7 commits intoKeKs0r:release_workflowfrom
Conversation
added 7 commits
November 27, 2019 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like this react component but there was one thing that felt a bit odd when using this framework.
When I subscribe an element to a certain topic this element would also get all the data from the topics it was not subscribed to and since there is no way in telling from what topic the data was comming from it really confused me.
So with this pull request I let the message event only forward to the handler when this element is subscribed to this topic.